To:  busybox@busybox.net
Subject: [PATCH] docs/contributing.txt *resend*
Content-Transfer-Encoding: 8bit
From: Peter Korsgaard <jacmet@sunsite.dk>
Date: 28 Oct 2003 22:27:31 +0100
Message-ID: <28b4qxtvyrg.fsf@sunsite.dk>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Lines: 69
Xref: sunsite.dk mbox-out:1002

--=-=-=

Hi,

A few references to sourcefiles and URLs in docs/contributing.txt had
gone stale - fixed.

Please apply.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=contributing.patch

Index: docs/contributing.txt
===================================================================
RCS file: /var/cvs/busybox/docs/contributing.txt,v
retrieving revision 1.8
diff -c -b -w -u -r1.8 contributing.txt
--- docs/contributing.txt	14 Jul 2003 21:20:48 -0000	1.8
+++ docs/contributing.txt	18 Oct 2003 13:05:45 -0000
@@ -171,7 +171,7 @@
 For a quick listing of "needs work" spots in the sources, cd into the Busybox
 directory and run the following:
 
-	for i in TODO FIXME XXX; do grep $i *.[ch]; done
+	for i in TODO FIXME XXX; do find -name '*.[ch]'|xargs grep $i; done
 
 This will show all of the trouble spots or 'questionable' code. Pick a spot,
 any spot, these are all invitations for you to contribute.
@@ -199,16 +199,16 @@
 
 These are dirty jobs, but somebody's gotta do 'em.
 
- - Converting applets to use getopt() for option processing. Type 'grep -L
-   getopt *.c' to get a listing of the applets that currently don't use
-   getopt. If a .c file processes no options, it should have a line that
+ - Converting applets to use getopt() for option processing. Type 'find -name
+   '*.c'|grep -L getopt' to get a listing of the applets that currently don't
+   use getopt. If a .c file processes no options, it should have a line that
    reads: /* no options, no getopt */ somewhere in the file.
 
  - Replace any "naked" calls to malloc, calloc, realloc, str[n]dup, fopen with
-   the x* equivalents found in utility.c.
+   the x* equivalents found in libbb/xfuncs.c.
 
  - Security audits:
-   http://www.securityfocus.com/frames/?content=/forums/secprog/secure-programming.html
+   http://www.securityfocus.com/popups/forums/secprog/intro.shtml
 
  - Synthetic code removal: http://www.perl.com/pub/2000/06/commify.html - This
    is very Perl-specific, but the advice given in here applies equally well to
@@ -231,7 +231,7 @@
 
  - "Ten Commandments" compliance: (this is a "maybe", certainly not as
    important as any of the previous items.)
-    http://web.onetelnet.ch/~twolf/tw/c/ten_commandments.html
+    http://www.lysator.liu.se/c/ten-commandments.html   
 
 Other useful links:
 

--=-=-=


-- 
Bye, Peter Korsgaard

--=-=-=--